Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call fetch hook when retrieving external import maps. Resolves #2374. #2376

Merged
merged 3 commits into from Jan 21, 2022
Merged

Call fetch hook when retrieving external import maps. Resolves #2374. #2376

merged 3 commits into from Jan 21, 2022

Conversation

joeldenning
Copy link
Collaborator

See #2374

@joeldenning
Copy link
Collaborator Author

@guybedford can you review this one

@joeldenning joeldenning mentioned this pull request Dec 23, 2021
Closed
@github-actions
Copy link

github-actions bot commented Dec 23, 2021 •
edited

File size impact

Merging issue-2374 into main will impact 4 files in 3 groups.

browser (2/2)
File raw gzip brotli Event
dist/s.min.js +31 (7,631) +19 (3,011) +14 (2,726) modified
dist/system.min.js +57 (11,946) +32 (4,609) +22 (4,146) modified
Total size impact +88 (19,577) +51 (7,620) +36 (6,872)
node (1/1)
File raw gzip brotli Event
dist/system-node.cjs +165 (518,948) +53 (126,143) 0 (84,058) modified
Total size impact +165 (518,948) +53 (126,143) 0 (84,058)
extras (1/8)
File raw gzip brotli Event
dist/extras/module-types.min.js +26 (2,815) +15 (1,212) +10 (1,064) modified
Total size impact +26 (2,815) +15 (1,212) +10 (1,064)
Generated by file size impact during size-impact#1616667146

@joeldenning joeldenning merged commit e586338 into main Jan 21, 2022
@joeldenning joeldenning deleted the issue-2374 branch January 21, 2022 22:45
@joeldenning
Copy link
Collaborator Author

Published in https://github.com/systemjs/systemjs/releases/tag/6.12.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guybedford guybedford guybedford approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joeldenning @guybedford