-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(core): don't parse 'requires' from strings or comments or regexes #2393
Draft
markwhitfeld
wants to merge
9
commits into
systemjs:0.21
Choose a base branch
from
markwhitfeld:fix/dont-parse-requires-in-strings
base: 0.21
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
fix(core): don't parse 'requires' from strings or comments or regexes #2393
markwhitfeld
wants to merge
9
commits into
systemjs:0.21
from
markwhitfeld:fix/dont-parse-requires-in-strings
Commits on Apr 29, 2022
-
This is a simple bump to check if the node 4 run is currently broken through deps packages that don't support node 4
Configuration menu - View commit details
-
Copy full SHA for 7e49ff5 - Browse repository at this point
Copy the full SHA 7e49ff5View commit details -
ci: drop node 4 from ci checks
Node 4 is broken due to deps that no longer support it. It is also way out of LTS.
Configuration menu - View commit details
-
Copy full SHA for b17bff0 - Browse repository at this point
Copy the full SHA b17bff0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 19ae527 - Browse repository at this point
Copy the full SHA 19ae527View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2000b19 - Browse repository at this point
Copy the full SHA 2000b19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9103f2f - Browse repository at this point
Copy the full SHA 9103f2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8ab1f73 - Browse repository at this point
Copy the full SHA 8ab1f73View commit details -
Configuration menu - View commit details
-
Copy full SHA for d107753 - Browse repository at this point
Copy the full SHA d107753View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0b52cd - Browse repository at this point
Copy the full SHA e0b52cdView commit details
Commits on Apr 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 656bfb3 - Browse repository at this point
Copy the full SHA 656bfb3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.