expose addImportMap

[wenerme]

fix #2428

[github-actions]

---

Error: Error while trying to generate a snapshot for applyImportMap merge into main.

Error: Command failed: git fetch --no-tags --prune origin refs/pull/2429/merge
fatal: couldn't find remote ref refs/pull/2429/merge

    at ChildProcess.exithandler (node:child_process:400:12)
    at ChildProcess.emit (node:events:513:28)
    at maybeClose (node:internal/child_process:1093:16)
    at Socket. (node:internal/child_process:451:11)
    at Socket.emit (node:events:513:28)
    at Pipe. (node:net:757:14)

---

_{Generated by file size impact during size-impact#3136268560}

[wenerme]

I don't get the test error, can't find any error messages, running in local seems fine.

[guybedford]

The tests seem to be failing here, can you look into it?

[wenerme]

@guybedford Sorry, but I have no idea why test failed, it's like firefox failed or something, can you have a look ?

[guybedford]

@wenerme for local testing, run chomp test:browser. In the Firefox window I'm seeing this error:

[wenerme]

Running browser test in macos

CI_BROWSER=/Applications/Firefox.app/Contents/MacOS/firefox chomp test

[guybedford]

This is looking good, we just need to add some documentation on the method as well to the SystemJS API documentation.

Also, in terms of the API name, how about addImportMap instead of applyImportMap? That would also match the corresponding methods in the ES module shims project (https://github.com/guybedford/es-module-shims#reading-current-import-map-state)

[wenerme]

add more precisely, renamed to addImportMap, add some doc about addImportMap

[guybedford]

Looks great, thanks for working on this.

Note in es module shims we explicitly avoid overrides when doing this per https://github.com/guybedford/es-module-shims#overriding-import-map-entries, with overrides explicily enabled via configuration. Worth noting but perhaps SystemJS doesn't need this as much.