Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactored db_sqlite.rs and the usage. #231

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactored db_sqlite.rs and the usage. #231

wants to merge 1 commit into from

Conversation

javerik
Copy link

@javerik javerik commented Oct 13, 2023

Issue

  • Creation of database was only done on request.
  • Crash when database queries would not be successful

Changes

  • Database gets created on startup
  • Moved creation and recreation to own function to prevent duplicates of create sql query
  • Error handling of database queries in terms of logging and HTTP error

@scharerox
Refactored db_sqlite.rs and the usage.
8365966 
Init of database on startup.
Error handling of database error in
terms of logging and HTTP error responses
@kendofriendo kendofriendo mentioned this pull request Nov 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@javerik @scharerox