Fix default retry option value when specifying a number (sindresorh…

…us#809) Co-authored-by: Szymon Marczak <sz.marczak@gmail.com>
szmarczak · Jun 25, 2019 · d97532d · d97532d
1 parent c82447c
commit d97532d
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 3 deletions.
diff --git a/source/merge.ts b/source/merge.ts
@@ -52,7 +52,24 @@ export default function merge<Target extends Record<string, unknown>, Source ext
 }
 
 export function mergeOptions<T extends Options>(...sources: T[]): T & {hooks: Partial<Hooks>} {
-	const mergedOptions = merge({} as T & {hooks: Partial<Hooks>}, ...sources.map(source => source || {}));
+	sources = sources.map(source => {
+		if (!source) {
+			return {};
+		}
+
+		if (is.object(source.retry)) {
+			return source;
+		}
+
+		return {
+			...source,
+			retry: {
+				retries: source.retry
+			}
+		};
+	}) as T[];
+
+	const mergedOptions = merge({} as T & {hooks: Partial<Hooks>}, ...sources);
 
 	const hooks = knownHookEvents.reduce((accumulator, current) => ({...accumulator, [current]: []}), {}) as Record<HookEvent, HookType[]>;
 

diff --git a/test/retry.ts b/test/retry.ts
@@ -274,7 +274,7 @@ test('doesn\'t retry when set to false', withServer, async (t, server, got) => {
 	t.is(retryCount, 0);
 });
 
-test('works when defaults.options.retry is not an object', withServer, async (t, server, got) => {
+test('works when defaults.options.retry is a number', withServer, async (t, server, got) => {
 	server.get('/', handler413);
 
 	const instance = got.extend({
@@ -284,7 +284,7 @@ test('works when defaults.options.retry is not an object', withServer, async (t,
 	const {retryCount} = await instance({
 		throwHttpErrors: false
 	});
-	t.is(retryCount, 0);
+	t.is(retryCount, 2);
 });
 
 test('retry function can throw', withServer, async (t, server, got) => {