Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support function in timeFormat #485

Open
wants to merge 1 commit into
base: v3
Choose a base branch
from
Open

Support function in timeFormat #485

wants to merge 1 commit into from

Conversation

thienvu18
Copy link

No description provided.

@vercel
Copy link

vercel bot commented Mar 7, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/t1m0n/air-datepicker/FsLUGC54s7L7CNHigfBSkUQCV9qo
✅ Preview: https://air-datepicker-git-fork-thienvu18-v3-t1m0n.vercel.app

@t1m0n
Copy link
Owner

t1m0n commented May 31, 2022

@thienvu18 Thank you for your PR! I'm sorry for the late answer.

I've looked through your changes, and it seems to me that it may be confusing to have timeFormat as function only in onlyTimepicker mode.

I think that, in onlyTimepicker mode user could use dateFormat as function to format time, as it would be in normal mode with date selection. In such case there would be some consistency in behaviour as dateFormat function fully shifts responsibility in formatting date\time to user in both modes. And it takes only one line of code to change).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants