Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump next to 12.3 #410

Closed
wants to merge 1 commit into from
Closed

chore: bump next to 12.3 #410

wants to merge 1 commit into from

Conversation

juliusmarminge
Copy link
Member

Closes #

βœ… Checklist

  • I have followed every step in the contributing guide (updated 2022-08-15).
  • The PR title follows the convention we established conventional-commit
  • I performed a functional test on my final commit

Changelog

[Short description of what has changed]


Screenshots

[Screenshots]

πŸ’―

@vercel
Copy link

vercel bot commented Sep 8, 2022

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Updated
create-t3-app βœ… Ready (Inspect) Visit Preview Sep 8, 2022 at 8:01PM (UTC)

@changeset-bot
Copy link

changeset-bot bot commented Sep 8, 2022

πŸ¦‹ Changeset detected

Latest commit: b0765e8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-t3-app Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliusmarminge
Copy link
Member Author

hmm have they changed something in the AppType typedefintion?

@c-ehrlich
Copy link
Member

yes, seems to be some change in the typedef

./src/pages/_app.tsx:13:16
Type error: Property 'session' does not exist on type '{}'.

  11 | const MyApp: AppType = ({
  12 |   Component,
> 13 |   pageProps: { session, ...pageProps },
     |                ^
  14 | }) => {
  15 |   return (
  16 |     <SessionProvider session={session}>

@juliusmarminge
Copy link
Member Author

yes, seems to be some change in the typedef

./src/pages/_app.tsx:13:16
Type error: Property 'session' does not exist on type '{}'.

  11 | const MyApp: AppType = ({
  12 |   Component,
> 13 |   pageProps: { session, ...pageProps },
     |                ^
  14 | }) => {
  15 |   return (
  16 |     <SessionProvider session={session}>

ill post an issue on their side to see if this is intended

@c-ehrlich
Copy link
Member

c-ehrlich commented Sep 8, 2022

12.2:

export declare type AppInitialProps = {
    pageProps: any;
};
export declare type AppPropsType<R extends NextRouter = NextRouter, P = {}> = AppInitialProps & {
    Component: NextComponentType<NextPageContext, any, P>;
    router: R;
    __N_SSG?: boolean;
    __N_SSP?: boolean;
    __N_RSC?: boolean;
};

12.3:

export declare type AppInitialProps<P = any> = {
    pageProps: P;
};
export declare type AppPropsType<R extends NextRouter = NextRouter, P = {}> = AppInitialProps<P> & {
    Component: NextComponentType<NextPageContext, any, any>;
    router: R;
    __N_SSG?: boolean;
    __N_SSP?: boolean;
    __N_RSC?: boolean;
};

I think it's because {} is getting passed to AppInitialProps's pageProps now

@juliusmarminge
Copy link
Member Author

vercel/next.js#40371

@juliusmarminge
Copy link
Member Author

this seems like something they'd wanna mention in the release notes...

@juliusmarminge
Copy link
Member Author

juliusmarminge commented Sep 9, 2022

We'll wait until 12.3.1 is out so we can utilize the new generic AppType<P> type

@juliusmarminge
Copy link
Member Author

continued in #485

@nexxeln nexxeln deleted the julius/next-bump branch September 20, 2022 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ“Œ area: t3-app Relates to the generated T3 App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants