Add explicit return types #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@colinhacks is attempting to deploy a commit to the t3-oss Team on Vercel. A member of the Team first needs to authorize it. |
colinhacks
commented
Apr 22, 2024
| @@ -18,10 +18,15 @@ type Options< | |||
|
|
|||
| export function createEnv< | |||
| TServer extends Record<string, ZodType> = NonNullable<unknown>, | |||
| TClient extends Record<string, ZodType> = NonNullable<unknown>, | |||
| TClient extends Record< | |||
There was a problem hiding this comment.
I changed this to agree with the Next.js behavior (enforcing the prefix). Feel free to undo if there was a reason for this decision.
This was referenced Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a
CreateEnvutility type incore/index.ts. This type is then used to provide an explicit return type for the framework-specificcreateEnvcalls. This would have prevented the Zod 3.23.0 declaration issue.