Skip to content

Commit

Permalink
fix: drop nativeWindowOpen deprecation warning (electron#32370)
Browse files Browse the repository at this point in the history
  • Loading branch information
nornagon authored and t57ser committed Jan 25, 2022
1 parent edde1c8 commit 7644fb4
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions lib/browser/api/web-contents.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { app, ipcMain, session, deprecate, webFrameMain } from 'electron/main';
import { app, ipcMain, session, webFrameMain } from 'electron/main';
import type { BrowserWindowConstructorOptions, LoadURLOptions } from 'electron/main';

import * as url from 'url';
Expand Down Expand Up @@ -752,11 +752,6 @@ WebContents.prototype._init = function () {
closeWithOpener
});
});

const prefs = this.getLastWebPreferences() || {};
if (prefs.nativeWindowOpen === false) {
deprecate.log('Deprecation Warning: Disabling nativeWindowOpen is deprecated. The nativeWindowOpen option will be removed in Electron 18.');
}
}

this.on('login', (event, ...args) => {
Expand Down

0 comments on commit 7644fb4

Please sign in to comment.