Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #213

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update README.md #213

wants to merge 1 commit into from

Conversation

pintaf
Copy link

@pintaf pintaf commented Mar 7, 2024

As per my test, the default behaviour is to follow the browser dark mode

As per my test, the default behaviour is to follow the browser dark mode
@ciminelli
Copy link
Member

Hi @pintaf ! I'm not sure if the darkMode param gets set depending on the browser settings. Could you elaborate on your testing?

@pintaf
Copy link
Author

pintaf commented Mar 8, 2024

Oh my god I feel dumb...
I had copy pasted the JS piece of code in README, which carries darkMode = true, but didn't noticed this
And since the docs said this is set to false by default, and it was in black for me, I thought it was taking the default browser setting.

So happy to update my PR in order to add this support of default darkmode being the browser mode, and could be overrided by darkmode setting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants