Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Internationalization support #215

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Internationalization support #215

wants to merge 4 commits into from

Conversation

civan
Copy link
Collaborator

@civan civan commented Mar 8, 2024 •
edited

Proposed implementation:

  • The importer has predefined languages but the consumer can still override these translations
const  customTranslations: {
    jp: {
      "Upload": "アップロード",
      "Browse files": "ファイルを参照",
    },
    pt: {
      "Upload": "Carregar",
      "Browse files": "Procurar arquivos",
    },
  }

<CSVImporter language="es" customTranslations={customTranslations}  ...props />
Screencast.from.03-08-2024.12.55.20.PM.webm

Related Issue: #84

@civan civan changed the title [WIP] Initial support for languages Internationalization support Mar 11, 2024
@civan civan marked this pull request as ready for review March 11, 2024 21:18
@civan civan requested a review from ciminelli March 11, 2024 21:19
@kedrigen
Copy link

Hi,

Any idea when this will be merged?

@johnwards
Copy link

This looks good, any idea when we'll get a release with this in it? @ciminelli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ciminelli ciminelli Awaiting requested review from ciminelli

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@civan @kedrigen @johnwards