Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure http cache size via upstream setting. #1985

Closed
laststylebender14 opened this issue May 19, 2024 · 0 comments · Fixed by #1988
Closed

feat: configure http cache size via upstream setting. #1985

laststylebender14 opened this issue May 19, 2024 · 0 comments · Fixed by #1988
Labels
good first issue Good for newcomers.

Comments

@laststylebender14
Copy link
Contributor

Currently, there is no provision to set the HTTP cache size. it can only be enabled or disabled using the httpCache setting in upstream. We want to enhance this functionality to allow users to set the cache size via an upstream setting.

Current Configuration:

@upstream(httpCache: true)

Expected Configuration:

@upstream(httpCache: 128)

The HTTP cache should be enabled only when the cache size is greater than 0; otherwise, it should be disabled.

Technical Requirements

  • Implement the ability to set the HTTP cache size.
  • Enable HTTP cache only when the specified size is greater than 0.
  • Add unit tests wherever necessary to cover the new functionality.
  • Update the website documentation to reflect the new usage of httpCache.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants