Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: configure http cache size through upstream setting #1988

Merged

Conversation

laststylebender14
Copy link
Contributor

@laststylebender14 laststylebender14 commented May 20, 2024

Summary:

Issue Reference(s):
Fixes #1985

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have added relevant unit & integration tests.
  • I have updated the documentation accordingly.
  • I have performed a self-review of my code.
  • PR follows the naming convention of <type>(<optional scope>): <title>

laststylebender14 and others added 30 commits May 10, 2024 17:05
- use MokaCache from http_cache_reqwest
- added support in HttpCacheManager to accept cache_size as input.
- used 42 as cache size as it was default in cache manager.
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 98.98990% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.61%. Comparing base (677ecad) to head (da5b8cd).

Files Patch % Lines
src/core/runtime.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1988      +/-   ##
==========================================
+ Coverage   82.50%   82.61%   +0.10%     
==========================================
  Files         174      174              
  Lines       17849    17926      +77     
==========================================
+ Hits        14727    14809      +82     
+ Misses       3122     3117       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented May 20, 2024

🐰Bencher

ReportWed, May 22, 2024 at 14:39:57 UTC
Projecttailcall
Branch1988/merge
Testbedbenchmarking-runner

🚨 1 ALERT: Threshold Boundary Limit exceeded!
BenchmarkMeasure (units)ViewValueLower BoundaryUpper Boundary
input/vars.missingLatency (nanoseconds (ns))🚨 (view plot | view alert)11.58 (+33.47%)11.33 (102.17%)

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns) | (Δ%)
Latency Upper Boundary
nanoseconds (ns) | (%)
group_by✅ (view plot)542.94 (-8.98%)650.49 (83.47%)
input/args.missing✅ (view plot)22.54 (-8.60%)27.20 (82.88%)
input/args.nested.existing✅ (view plot)41.52 (-19.50%)65.89 (63.01%)
input/args.nested.missing✅ (view plot)37.89 (-1.53%)40.64 (93.23%)
input/args.root✅ (view plot)38.26 (-20.50%)62.41 (61.31%)
input/headers.existing✅ (view plot)30.38 (-4.39%)33.52 (90.64%)
input/headers.missing✅ (view plot)29.29 (-4.82%)33.37 (87.79%)
input/value.missing✅ (view plot)23.12 (-1.80%)25.32 (91.31%)
input/value.nested.existing✅ (view plot)42.55 (+2.58%)43.92 (96.87%)
input/value.nested.missing✅ (view plot)37.36 (+2.61%)38.34 (97.44%)
input/value.root✅ (view plot)35.25 (-8.30%)40.40 (87.26%)
input/vars.existing✅ (view plot)7.50 (-7.78%)9.06 (82.82%)
input/vars.missing🚨 (view plot | view alert)11.58 (+33.47%)11.33 (102.17%)
test_batched_body✅ (view plot)2,690.20 (-99.67%)2,611,964.31 (0.10%)
test_batched_body #2✅ (view plot)1,652,400.00 (-4.66%)1,881,579.65 (87.82%)
test_data_loader✅ (view plot)464,740.00 (-1.54%)490,095.74 (94.83%)
test_handle_request✅ (view plot)162,130.00 (-3.58%)184,364.76 (87.94%)
test_http_execute_method✅ (view plot)18,225.00 (+0.50%)18,880.41 (96.53%)
with_mustache_expressions✅ (view plot)1,181.10 (+0.89%)1,234.77 (95.65%)
with_mustache_literal✅ (view plot)749.54 (+3.58%)771.80 (97.12%)

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@laststylebender14 laststylebender14 changed the title Feat/configure http cache size through upstream setting feat: configure http cache size through upstream setting May 20, 2024
@laststylebender14 laststylebender14 removed the ci: benchmark Runs benchmarks label May 20, 2024
@laststylebender14 laststylebender14 marked this pull request as ready for review May 20, 2024 08:16
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label May 20, 2024
@laststylebender14 laststylebender14 removed the ci: benchmark Runs benchmarks label May 20, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label May 20, 2024
@laststylebender14 laststylebender14 removed the ci: benchmark Runs benchmarks label May 20, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label May 22, 2024
@tusharmath tusharmath removed the ci: benchmark Runs benchmarks label May 22, 2024
@github-actions github-actions bot added the ci: benchmark Runs benchmarks label May 22, 2024
@tusharmath tusharmath enabled auto-merge (squash) May 22, 2024 14:25
@tusharmath tusharmath merged commit b048f7c into main May 22, 2024
27 checks passed
@tusharmath tusharmath deleted the feat/configure-http-cache-size-through-upstream-setting branch May 22, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci: benchmark Runs benchmarks type: feature Brand new functionality, features, pages, workflows, endpoints, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: configure http cache size via upstream setting.
2 participants