-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configure http cache size through upstream setting #1988
Merged
tusharmath
merged 48 commits into
main
from
feat/configure-http-cache-size-through-upstream-setting
May 22, 2024
Merged
feat: configure http cache size through upstream setting #1988
tusharmath
merged 48 commits into
main
from
feat/configure-http-cache-size-through-upstream-setting
May 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use MokaCache from http_cache_reqwest
- added support in HttpCacheManager to accept cache_size as input.
- used 42 as cache size as it was default in cache manager.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1988 +/- ##
==========================================
+ Coverage 82.50% 82.61% +0.10%
==========================================
Files 174 174
Lines 17849 17926 +77
==========================================
+ Hits 14727 14809 +82
+ Misses 3122 3117 -5 ☔ View full report in Codecov by Sentry. |
Bencher
🚨 1 ALERT: Threshold Boundary Limit exceeded!
Click to view all benchmark results
Bencher - Continuous Benchmarking View Public Perf Page Docs | Repo | Chat | Help |
laststylebender14
changed the title
Feat/configure http cache size through upstream setting
feat: configure http cache size through upstream setting
May 20, 2024
- added unit tests to test eviction policy.
tusharmath
approved these changes
May 22, 2024
tusharmath
deleted the
feat/configure-http-cache-size-through-upstream-setting
branch
May 22, 2024 14:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci: benchmark
Runs benchmarks
type: feature
Brand new functionality, features, pages, workflows, endpoints, etc.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Issue Reference(s):
Fixes #1985
Build & Testing:
cargo test
successfully../lint.sh --mode=fix
to fix all linting issues raised by./lint.sh --mode=check
.Checklist:
<type>(<optional scope>): <title>