Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npm publish issue with glib #633

Conversation

ologbonowiwi
Copy link
Contributor

@ologbonowiwi ologbonowiwi commented Nov 14, 2023

  • build: add libc to generated package.json
  • refactor: delete post-install script

Summary:
Replacing post-install script by libc field on package.json (which is handled automatically by Node.js)

Issue Reference(s):
Fixes #628

Build & Testing:

  • I ran cargo test successfully.
  • I have run ./lint.sh --mode=fix to fix all linting issues raised by ./lint.sh --mode=check.

Checklist:

  • I have performed a self-review of my own code.

@neo773
Copy link
Contributor

neo773 commented Nov 14, 2023

This might get problematic as support for libc field landed quite recently in npm@9.6.5

We'll also have to account for third party package managers like yarn and pnpm

@ologbonowiwi
Copy link
Contributor Author

I know that yarn, pnpm and bun already supports, but I didn't knew about the version restriction on NPM.

maybe we should close this @meskill?

@meskill
Copy link
Contributor

meskill commented Nov 15, 2023

This might get problematic as support for libc field landed quite recently in npm@9.6.5

We'll also have to account for third party package managers like yarn and pnpm

there is already npm@10 and the v9 is shipped with the node18 that soon will enter maintence stage. So, we could actually just support those active versions for npm and probably for other package managers as well.

I suggest also to take a look into swc repo and issues and search for any issues they have with libc field as I saw they are using this approach

@amitksingh1490 amitksingh1490 force-pushed the refactor/#628/replace-postinstall-for-libc-field branch from b6ff97b to 300634d Compare November 17, 2023 08:35
npm/post-install.js Outdated Show resolved Hide resolved
@tusharmath tusharmath changed the title refactor/#628/replace postinstall for libc field fix: npm publish issue with glib Nov 17, 2023
@tusharmath tusharmath added the bug label Nov 17, 2023
@tusharmath tusharmath enabled auto-merge (squash) November 17, 2023 08:43
@tusharmath tusharmath merged commit 0fb53ce into tailcallhq:main Nov 17, 2023
8 checks passed
@ologbonowiwi ologbonowiwi deleted the refactor/#628/replace-postinstall-for-libc-field branch November 18, 2023 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace postinstall script for npm packages with libc field in package.json
5 participants