Update go1.22.0 #84
Merged
Update go1.22.0 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jenny Zhang <jz@tailscale.com>
…nspecified addr listens For debugging Mac firewall dialog boxes blocking+failing tests. Change-Id: Ic1a0cd51de7fe553de1c1c9333fa1cc75b8490f2 (cherry picked from commit 8c9eff4)
Git checkouts are not reproducible (in particular, the .git directory's hashes vary according to the moods of git re: packing and other local settings), so building our Go toolchain via Nix leads to source hashes that change from machine to machine and over time. Since Nix already knows the exact git revision it's building from, this change lets Nix provide that hash to cmd/dist directly, skipping the rooting around in .git to find the right hash. Signed-off-by: Jenny Zhang <jz@tailscale.com> (cherry picked from commit 6a17f14)
Lets us build a statically linked toolchain that has the same cgo behavior as the standard dynamic toolchain. Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from a2f29de)
Updates #55 Updates tailscale/corp#8944 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from 13373ca)
Loosely inspired by nettrace/httptrace, allows functions to be called when sockets are read from or written to. The hooks are specified via the context (with a WithSockTrace function). Only implemented for network sockets on POSIX systems. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from fb11c0d)
Extends the hooks added by #45 to also expose when TCP sockets are created or closed (meant to allow TCP stats to be read from them). We don't do this for all socket types since stats are not available for UDP sockets, and they tend to be short-lived, thus invoking the hooks would be useless overhead. Also fixes read/write hooks to not count out-of-band data, since that's usually not sent over the wire. Updates tailscale/corp#9230 Updates #58 Signed-off-by: Jenny Zhang <jz@tailscale.com> (Cherry-picked from db4dc90)
…ke our net ones Updates #55 Updates tailscale/corp#12702 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
…efault Updates #77 Updates tailscale/tailscale#9841 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
Need to rebuild 1.20.5 release to make `tool/gocross.sh` work in OSS for 1.44 release branch for a backport. Add manual dispatch to the release build action to allow that. Updates tailscale/corp#15405
Use the ref provided in input instead of latest main branch SHA to tag the release.
bradfitz
reviewed
Feb 7, 2024
There was a problem hiding this comment.
Thanks!
I guess net internals changed (per that build failure).
Is https://github.com/tailscale/go/issues still accurate, with an open issue per patch? (sometimes an issue is two commits or so and that's fine)
|
@bradfitz yep, fixed the breakage in the latest commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing a rebase got messy because of all the cherry-picks on the 1.21 branch.
Here's what I did:
tailscale.go1.22from upstreamrelease-branch.go1.22update-go1.22.0fromtailscale.go1.22(this PR branch)tailscale.go1.21intoupdate-go.1.22.0[tailscale]prefix to make our patches easier to find in the futureTo validate, here's the diff from upstream
release-branch.go1.21to ourtailscale.go1.21: golang/go@release-branch.go1.21...tailscale:go:tailscale.go1.21 - these are all the patches in our current toolchain.Here's the diff from upstream
release-branch.go1.22to this PR branch: golang/go@release-branch.go1.22...tailscale:go:update-go1.22.0It's identical, except for a change in
src/time/time.gothat has been upstreamed: golang@4467839Fixes #70