cgosqlite: implement BulkQuery/BulkExec #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Designed to minimize allocations and cgo calls.
API requires no allocations to INSERT or SELECT. (Apparently there is still one allocation, somewhere.) All cgo calls are amortized across rows.
bradfitz
reviewed
May 31, 2022
| func NewBulkQuery(stmt *Stmt) (*BulkQuery, error) { | ||
| b := &BulkQuery{ | ||
| bulkStmt: newBulkStmt(stmt), | ||
| dataText: make([]byte, 1<<16), |
There was a problem hiding this comment.
only do shifts of 10 (KiB), 20 (MiB), etc.
so 64 << 10. (64 KiB)
Comment on lines
+181
to
+183
| func (b *BulkQuery) resizeDataText() { | ||
| b.dataText = append(b.dataText, make([]byte, len(b.dataText))...) | ||
| } |
There was a problem hiding this comment.
rather than resizing this and generating garbage, my plan was for the C layer to signal to Go that the row won't fit and that it should be accessed using the C sqlite3 interface instead.
but because of where I was putting this, in Stmt, it wasn't extra work, because the C calls were already there.
There was a problem hiding this comment.
because of the way the iterator works, if a column doesn't fit, the row is punted to the next time the bulk query is run. so the only time dataText gets expanded is if someone tries to read a row more than 16kb, which generally shouldn't happen.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.