.github: add tests to CI #82
Conversation
.github/workflows/test-sqlite.yml
Outdated
|
|
||
| on: | ||
| push: | ||
| branches: [ $default-branch ] |
There was a problem hiding this comment.
Does this work here? I thought this was only for templates.
Do we need ${{ github.event.repository.default_branch }} ?
There was a problem hiding this comment.
look, all I do is copy the yaml from one file to another file. none of this makes any sense to me!
There was a problem hiding this comment.
ooh it worked this time!
lmk if you have a shorter form of this.
There was a problem hiding this comment.
Yeah, I mean I just put in the specific name. It's not like default branch names change all that often anyway.
crawshaw
force-pushed
the
crawshaw/testsqlite
branch
from
4cf1d93
to
b46370c
Compare
.github/workflows/test-sqlite.yml
Outdated
| push: | ||
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] |
There was a problem hiding this comment.
Consider maybe also
types: [opened, reopened, synchronize]There was a problem hiding this comment.
what does that do? (it seems to re-run on pushing to a PR already)
There was a problem hiding this comment.
Sorry, I meant that instead of specifying the branch for a PR, since we presumably want the tests to run not just for main.
There was a problem hiding this comment.
To be more specific:
on:
push:
branches:
- main
pull_request:
types: [opened, reopened, synchronize](syntax mutatis mutandis)
| branches: [ main ] | ||
| pull_request: | ||
| branches: [ main ] | ||
|
|
There was a problem hiding this comment.
| permissions: | |
| contents: read | |
though it is possible that is the default now.
There was a problem hiding this comment.
I think it is. Going to skip this on the principle that fewer lines is better.
There was a problem hiding this comment.
It looks like the default is read-all, which is more general (e.g., it allows access to readable properties of the repo besides the files), but that is probably not a big issue.
crawshaw
force-pushed
the
crawshaw/testsqlite
branch
from
b46370c
to
3c19dab
Compare
| run: go build -v ./... | ||
|
|
||
| - name: Test | ||
| run: go test -v ./... |
raggi
force-pushed
the
crawshaw/testsqlite
branch
from
3c19dab
to
9bde6c0
Compare
|
@creachadair i bumped this, added race as you suggested, LGTY? |
No description provided.