ipn/ipnlocal, control/controlclient: keep map poll alive on NoLogsNoSupport + flow logs #11825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport + flow logs Fixes #11793 Change-Id: I77eab157b6be24799805ece905855b6fecfa91c9 Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
dsnet
approved these changes
Apr 21, 2024
| @@ -1216,20 +1218,11 @@ func (b *LocalBackend) SetControlClientStatus(c controlclient.Client, st control | |||
|
|
|||
| if st.NetMap != nil { | |||
| if envknob.NoLogsNoSupport() && st.NetMap.HasCap(tailcfg.CapabilityDataPlaneAuditLogs) { | |||
| msg := "tailnet requires logging to be enabled. Remove --no-logs-no-support from tailscaled command line." | |||
| msg := "tailnet requires logging to be enabled. Remove --no-logs-no-support from the tailscaled command line." | |||
There was a problem hiding this comment.
Does this message get surfaced in the admin panel UI?
There was a problem hiding this comment.
Well, in theory. That's what the following line should be doing indirectly. It sets health as unhappy on the device and nodes should be telling control about their health state. But we don't do much with that server-side yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11793