net/dnscache: use parent context to perform lookup #11935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
added a commit
to coder/tailscale
that referenced
this pull request
Apr 30, 2024
kylecarbs
added a commit
to coder/tailscale
that referenced
this pull request
Apr 30, 2024
|
@kylecarbs mind adding a |
|
I have forgotten to do that so many times it's embarrassing! Yes, will do. |
andrew-d
added a commit
that referenced
this pull request
May 4, 2024
This is a variant of DoChan that supports context propagation, such that the context provided to the inner function will only be canceled when there are no more waiters for a given key. This can be used to deduplicate expensive and cancelable calls among multiple callers safely. Updates #11935 Signed-off-by: Andrew Dunham <andrew@du.nham.ca> Change-Id: Ibe1fb67442a854babbc6924fd8437b02cc9e7bcf
|
I took a look through this code, and I think the reason is that if the first call is canceled, other callers (that are still waiting) also see a spurious context cancelation since the first call canceled. I've submitted #12003 with a tweak to our I'll keep you posted. |
Seemingly no reason why it wasn't used. Signed-off-by: Kyle Carberry <kyle@carberry.com>
andrew-d
added a commit
that referenced
this pull request
May 7, 2024
This is a variant of DoChan that supports context propagation, such that the context provided to the inner function will only be canceled when there are no more waiters for a given key. This can be used to deduplicate expensive and cancelable calls among multiple callers safely. Updates #11935 Signed-off-by: Andrew Dunham <andrew@du.nham.ca> Change-Id: Ibe1fb67442a854babbc6924fd8437b02cc9e7bcf
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seemingly no reason why it wasn't used.