xcode: allow ICMP ping relay on macOS + iOS/tvOS platforms #12048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agottardo
force-pushed
the
10393-pinging-devices-using-subnet-routing-on-apple-tv-does-not-work
branch
2 times, most recently
from
e7920c8
to
38d5e00
Compare
bradfitz
reviewed
May 8, 2024
agottardo
force-pushed
the
10393-pinging-devices-using-subnet-routing-on-apple-tv-does-not-work
branch
2 times, most recently
from
adff786
to
c964cd4
Compare
agottardo
force-pushed
the
10393-pinging-devices-using-subnet-routing-on-apple-tv-does-not-work
branch
4 times, most recently
from
34492db
to
a1a14b5
Compare
agottardo
force-pushed
the
10393-pinging-devices-using-subnet-routing-on-apple-tv-does-not-work
branch
9 times, most recently
from
1e94e6d
to
6c33aaf
Compare
bradfitz
approved these changes
May 16, 2024
Fixes #10393 Fixes tailscale/corp#15412 Fixes tailscale/corp#19808 On Apple platforms, exit nodes and subnet routers have been unable to relay pings from Tailscale devices to non-Tailscale devices due to sandbox restrictions imposed on our network extensions by Apple. The sandbox prevented the code in netstack.go from spawning the `ping` process which we were using. Replace that exec call with logic to send an ICMP echo request directly, which appears to work in userspace, and not trigger a sandbox violation in the syslog. Signed-off-by: Andrea Gottardo <andrea@gottardo.me>
agottardo
force-pushed
the
10393-pinging-devices-using-subnet-routing-on-apple-tv-does-not-work
branch
from
6c33aaf
to
ef9a27f
Compare
agottardo
deleted the
10393-pinging-devices-using-subnet-routing-on-apple-tv-does-not-work
branch
Mmx233
pushed a commit
to MultiMx/tailscale
that referenced
this pull request
May 20, 2024
Fixes tailscale#10393 Fixes tailscale/corp#15412 Fixes tailscale/corp#19808 On Apple platforms, exit nodes and subnet routers have been unable to relay pings from Tailscale devices to non-Tailscale devices due to sandbox restrictions imposed on our network extensions by Apple. The sandbox prevented the code in netstack.go from spawning the `ping` process which we were using. Replace that exec call with logic to send an ICMP echo request directly, which appears to work in userspace, and not trigger a sandbox violation in the syslog. Signed-off-by: Andrea Gottardo <andrea@gottardo.me>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10393
Fixes tailscale/corp#15412
Fixes tailscale/corp#19808
On Apple platforms, exit nodes and subnet routers have been unable to relay pings from Tailscale devices to non-Tailscale devices due to sandbox restrictions imposed on our network extensions by Apple. The sandbox prevented the code in netstack.go from spawning the
pingprocess which we were using.Replace that exec call with logic to send an ICMP echo request directly, which appears to work in userspace, and not trigger a sandbox violation in the syslog.