ssh/tailssh: add support for forwarding unix sockets #12081
+661
−35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updates tailscale#6232 Signed-off-by: Samuel Corsi-House <chouse.samuel@gmail.com>
Updates tailscale#6232 Signed-off-by: Samuel Corsi-House <chouse.samuel@gmail.com>
Xenfo
commented
May 10, 2024
Comment on lines
+2460
to
+2467
| // AllowLocalUnixForwarding, if true, allows accepted connections | ||
| // to use local unix forwarding if requested. | ||
| AllowLocalUnixForwarding bool `json:"allowLocalUnixForwarding,omitempty"` | ||
|
|
||
| // AllowRemoteUnixForwarding, if true, allows accepted connections | ||
| // to use remote unix forwarding if requested. | ||
| AllowRemoteUnixForwarding bool `json:"allowRemoteUnixForwarding,omitempty"` | ||
|
|
There was a problem hiding this comment.
Not sure how to actually change these values on the client, could it be part of another project? Currently they seem to default to false.
Edit: Looking at Headscale's source code I think it's part of the proprietary code that Tailscale uses.
| return false, nil | ||
| } | ||
|
|
||
| if err := os.Chmod(addr, os.FileMode(0777)); err != nil { |
There was a problem hiding this comment.
Is there a better permission that can be used on the socket?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #6232
Based off of @deansheather's work at gliderlabs/ssh#196 and https://github.com/coder/coder/blob/2c0f653aa85ab4d2c4be410642776c772eb524ac/agent/agentssh/forward.go, this PR finally adds support for forwarding unix sockets. This allows workflows such as GPG agent forwarding to work.
Just as a side note, I'm not very familiar with networking and the security that comes with it so this code will probably need to be modified to meet whatever requirements Tailscale has during review.