Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: fix macOS uploads by increasing build number prefix #12134

Merged
merged 1 commit into from
May 14, 2024

Conversation

agottardo
Copy link
Contributor

@agottardo agottardo commented May 14, 2024

Fixes tailscale/corp#19979

A build with version number 275 was uploaded to the App Store without bumping OSS first. The presence of that build is causing any 274.* build to be rejected. To address this, added +1 to the year component, which means new builds will use the 275.* prefix.

@agottardo agottardo self-assigned this May 14, 2024
@agottardo agottardo force-pushed the angott/increase-macos-build-numbers branch from fb56a42 to c4cb25d Compare May 14, 2024 19:05
Copy link
Member

@barnstar barnstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we can only make this mistake 1749 more times?

Fixes tailscale/corp#19979

A build with version number 275 was uploaded to the App Store without bumping OSS first. The presence of that build is causing any 274.* build to be rejected. To address this, added -1 to the year component, which means new builds will use the 275.* prefix.

Signed-off-by: Andrea Gottardo <andrea@gottardo.me>
@agottardo agottardo force-pushed the angott/increase-macos-build-numbers branch from c4cb25d to db8c1e8 Compare May 14, 2024 19:09
@agottardo agottardo merged commit 60266be into main May 14, 2024
46 checks passed
@agottardo agottardo deleted the angott/increase-macos-build-numbers branch May 14, 2024 19:15
nickoneill pushed a commit that referenced this pull request May 14, 2024
Fixes tailscale/corp#19979

A build with version number 275 was uploaded to the App Store without bumping OSS first. The presence of that build is causing any 274.* build to be rejected. To address this, added -1 to the year component, which means new builds will use the 275.* prefix.

Signed-off-by: Andrea Gottardo <andrea@gottardo.me>
(cherry picked from commit 60266be)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants