Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version: use Go 1.18's git stamping as default implementation #4185

Merged
merged 1 commit into from Mar 16, 2022

Conversation

bradfitz
Copy link
Member

No more manual version bumps!

Fixes #81

@bradfitz bradfitz requested a review from danderson March 16, 2022 20:59
@bradfitz
Copy link
Member Author

bradfitz@tsdev:~/src/tailscale.com$ go run ./cmd/tailscale debug hostinfo
{
  "IPNVersion": "1.23.0-dev20220316-t8b36a39fb-dirty",
  "OS": "linux",
  "OSVersion": "Debian 11.2 (bullseye); kernel=5.10.0-10-amd64",
  "Hostname": "tsdev",
  "GoArch": "amd64"
}

bradfitz@tsdev:~/src/tailscale.com$ go run ./cmd/tailscale version
1.23.0-dev20220316
  tailscale commit: 8b36a39fb5b2cdd6908a910ee818175035c830ca-dirty
  go version: go1.18

@bradfitz
Copy link
Member Author

cc @josharian

version/version.go Outdated Show resolved Hide resolved
No more manual version bumps!

Fixes #81

Change-Id: I3a9e544a7248f0b83bcbacbaabbc4dabc435e62d
Signed-off-by: Brad Fitzpatrick <bradfitz@tailscale.com>
@bradfitz bradfitz merged commit 1f22507 into main Mar 16, 2022
@bradfitz bradfitz deleted the bradfitz/version branch March 16, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

version: come up with good default implementation
2 participants