Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
use
HTMLElement
for generic DOM node types (#3169)
We keep specific types for elements with special meaning, such as `HTMLButtonElement`, `HTMLLabelElement` or `HTMLInputElement` because they receive certain attributes that generic DOM nodes (such as HTMLDivElement) don't For the components where we use simple `div` elements (and where people use `as={...}`) that renders a different element, it doesn't make sense to use `HTMLDivElement`. Using a more generic `HTMLElement` is simpler and more correct (we still had `HTMLUListElement` and `HTMLLIElement` for "div" DOM nodes which is incorrect). This shouldn't be a breaking change because an `HTMLDivElement` is still a valid `HTMLElement`. The other way around wouldn't be the case.
- Loading branch information
1 parent
f0e3e5b
commit 0bd8c47
Showing
9 changed files
with
27 additions
and
27 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters