ensure cb in useOnUnmount is a stable reference

tailwindlabs · Apr 26, 2023 · 74c9873 · 74c9873 · vercel · Apr 26, 2023
1 parent 5cfbb4b
commit 74c9873
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/packages/@headlessui-react/src/hooks/use-on-unmount.ts b/packages/@headlessui-react/src/hooks/use-on-unmount.ts
@@ -1,7 +1,10 @@
 import { useRef, useEffect } from 'react'
 import { microTask } from '../utils/micro-task'
+import { useEvent } from './use-event'
 
 export function useOnUnmount(cb: () => void) {
+  let stableCb = useEvent(cb)
+
   let trulyUnmounted = useRef(false)
   useEffect(() => {
     trulyUnmounted.current = false
@@ -11,8 +14,8 @@ export function useOnUnmount(cb: () => void) {
       microTask(() => {
         if (!trulyUnmounted.current) return
 
-        cb()
+        stableCb()
       })
     }
-  }, [])
+  }, [stableCb])
 }