Improve Combobox input cursor position #1572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@danr-za is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
danr-za
force-pushed
the
fix/combobox-focus
branch
from
19571f7
to
1faaed9
Compare
| import { Hidden, Features as HiddenFeatures } from '../../internal/hidden' | ||
| import { useOpenClosed, State, OpenClosedProvider } from '../../internal/open-closed' | ||
| import { Features as HiddenFeatures, Hidden } from '../../internal/hidden' | ||
| import { OpenClosedProvider, State, useOpenClosed } from '../../internal/open-closed' |
There was a problem hiding this comment.
Please don't do all of this re-ordering in other projects :)
RobinMalfait
changed the title
|
Hey! Thank you for your PR! I've made some changes and started from your original branch. More info: #1574 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when selecting an option in the Combobox, the focus is causing the cursor to move to the beginning which happens because of RAF.
Focus using microtask fixes the behavior.