Fix getting Vue dom elements #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@NoelDeMartin is attempting to deploy a commit to the Tailwind Labs Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey! Thank you for your PR! This is odd, this definitely used to work. Thanks for the refactor! |
|
Using in works except with components which use defineExpose without reexposing $el. This is a bug in Vue and will be fixed in an upcoming PR 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like there is a bug trying to get the dom element from a Vue component. I got this problem trying to use a custom button to open a Menu.
Here's a reproduction of the issue: https://stackblitz.com/edit/vitejs-vite-rgp3jk?file=src/App.vue
I reproduced the error in the
playground-vueas well to test my fix.What I saw debugging the problem in my app is that
ref.valueis actually a Proxy. That's why doing'$el' in ref.valuereturns false, but doingref.value.$elactually works. I guess it has to do with the way that Vue references component instances, but I think this should be a safe refactor.Possibly related to vuejs/core#6137