Commits on Nov 23, 2022

1. make combobox playgrounds in React and Vue similar

   

   RobinMalfait committed Nov 23, 2022
   Copy the full SHA

   7a21475 View commit details

   Browse the repository at this point in the history

2. syncing of the input should happen when the value changes internally … …

   …or externally
   
   I also got rid of the manually dispatching of the change event if the
   value changes from internally.
   
   I think the correct mental model is:
   - That the `Combobox.Input` value should change if the selected value
     changes from the outside or from the inside.
     - Note: It should _not_ do that if you are currently typing (once you
       choose a new value it will re-sync, once you reset (escape / outside
       click) it will also sync again).
   - The `onChange`/`onInput` of the `Combobox.Input` itself should only be
     called if you as the user type something. Not when the value is
     "synced" based on the selected value. We were currently manually
     dispatching events which works (to a certain extend) but smelled a bit
     fishy to me.
   
   The manual dispatching of events tried to solve an issue
   (#1875), but I think
   this can be solved in 2 other ways that make a bit more sense:
   
   1. (Today) Use the `onBlur` on the input to reset the `query` value to filter
      options.
   2. (In the future)  Use an exposed `onClose` (or similar) event to reset
      your `query` value.

   

   RobinMalfait committed Nov 23, 2022
   Copy the full SHA

   a09dd84 View commit details

   Browse the repository at this point in the history

3. update changelog

   

   RobinMalfait committed Nov 23, 2022
   Copy the full SHA

   a1d0d84 View commit details

   Browse the repository at this point in the history

4. ignore flakey test

   

   RobinMalfait committed Nov 23, 2022
   Copy the full SHA

   de4bd7e View commit details

   Browse the repository at this point in the history