Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing in your own id prop #2060

Merged
merged 4 commits into from Dec 2, 2022
Merged

Allow passing in your own id prop #2060

merged 4 commits into from Dec 2, 2022

Commits on Dec 2, 2022

  1. accept id as a prop where it is currently hardcoded (React) 

    Continuation of #2020

Co-authored-by: Olivier Louvignes <olivier@mgcrea.io>
    @RobinMalfait @mgcrea
    RobinMalfait and mgcrea committed Dec 2, 2022
    Copy the full SHA
    a02b1ba View commit details
    Browse the repository at this point in the history

  2. accept id as a prop where it is currently hardcoded (Vue)

    @RobinMalfait
    RobinMalfait committed Dec 2, 2022
    Copy the full SHA
    289752d View commit details
    Browse the repository at this point in the history

  3. update changelog

    @RobinMalfait
    RobinMalfait committed Dec 2, 2022
    Copy the full SHA
    07439de View commit details
    Browse the repository at this point in the history

  4. apply React's hook rules

    @RobinMalfait
    RobinMalfait committed Dec 2, 2022
    Copy the full SHA
    4af9221 View commit details
    Browse the repository at this point in the history