Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression where displayValue crashes #2087

Merged
merged 2 commits into from Dec 12, 2022
Merged

Fix regression where displayValue crashes #2087

merged 2 commits into from Dec 12, 2022

Commits on Dec 12, 2022

  1. fix regression where displayValue crashes 

    It regressed in the sense that it now uses `displayValue` for the
`defaultValue` as well, but if nothing is passed it would crash.

Right now, it makes sure to only run the displayValue value on the
actual value and the actual default value if they are not undefined.

Note: if your displayValue is implemented like `(value) => value.name`,
and your `value` is passed as `null`, it will still crash (as expected)
because then you are in charge of rendering something else than null. If
we would "fix" this, then no value can be rendered instead of `null`.

Fixes: #2084
    @RobinMalfait
    RobinMalfait committed Dec 12, 2022
    Copy the full SHA
    42ea386 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Dec 12, 2022
    Copy the full SHA
    0e5bab7 View commit details
    Browse the repository at this point in the history