Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix displayValue syncing when Combobox.Input is unmounted and re-mounted in different trees #2090

Merged
merged 2 commits into from Dec 12, 2022
Merged

Fix displayValue syncing when Combobox.Input is unmounted and re-mounted in different trees #2090

merged 2 commits into from Dec 12, 2022

Commits on Dec 12, 2022

  1. simplify currentDisplayValue calculation 

    Always calculate the currentDisplayValue, and only apply it if the user
is not typing. In all other cases it can be applied (e.g.: when the
value changes from the outside, inside or on reset)
    @RobinMalfait
    RobinMalfait committed Dec 12, 2022
    Copy the full SHA
    cc9903a View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Dec 12, 2022
    Copy the full SHA
    2bf712e View commit details
    Browse the repository at this point in the history