Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix className hydration for <Transition appear> #2390

Merged
merged 2 commits into from Mar 22, 2023
Merged

Fix className hydration for <Transition appear> #2390

merged 2 commits into from Mar 22, 2023

Conversation

thecrypticace
Copy link
Contributor

Fixes #2167

@RobinMalfait Does this seem right to you or is there something else I should look at? I'll port this to Vue once confirmed.

@vercel
Copy link

vercel bot commented Mar 21, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 3:39PM (UTC)
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 22, 2023 at 3:39PM (UTC)

@RobinMalfait
Copy link
Collaborator

Hmm, I feel like we added that env.isServer explicitly to fix another issue.

Looking at the history, I introduced it here: #2059 to solve this issue: #2012 so if we can ensure that it still works (we probably want to introduce another test if that breaks) then I think this is good.

@thecrypticace thecrypticace force-pushed the fix/transition-appear-hydrate-classname branch from 460f75d to 0ab003f Compare March 22, 2023 15:04
@thecrypticace thecrypticace force-pushed the fix/transition-appear-hydrate-classname branch from 0ab003f to 16adff2 Compare March 22, 2023 15:38
@thecrypticace thecrypticace merged commit f4e9710 into main Mar 22, 2023
5 checks passed
@thecrypticace thecrypticace deleted the fix/transition-appear-hydrate-classname branch March 22, 2023 15:41
@thecrypticace thecrypticace mentioned this pull request Mar 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RobinMalfait RobinMalfait Awaiting requested review from RobinMalfait

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

<Transition /> overwrites the className of the child component in SSR
2 participants
@thecrypticace @RobinMalfait