Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve control over Menu and Listbox options while searching #2471

Merged
merged 9 commits into from
May 4, 2023
Merged

Improve control over Menu and Listbox options while searching #2471

merged 9 commits into from
May 4, 2023

Commits on May 2, 2023

  1. add get-text-value helper

    @RobinMalfait
    RobinMalfait committed May 2, 2023
    Configuration menu
    Copy the full SHA
    7a84932 View commit details
    Browse the repository at this point in the history

  2. use getTextValue in Listbox component

    @RobinMalfait
    RobinMalfait committed May 2, 2023
    Configuration menu
    Copy the full SHA
    21a293d View commit details
    Browse the repository at this point in the history

  3. use getTextValue in Menu component

    @RobinMalfait
    RobinMalfait committed May 2, 2023
    Configuration menu
    Copy the full SHA
    98a81e1 View commit details
    Browse the repository at this point in the history

  4. update changelog

    @RobinMalfait
    RobinMalfait committed May 2, 2023
    Configuration menu
    Copy the full SHA
    ccd5914 View commit details
    Browse the repository at this point in the history

Commits on May 3, 2023

  1. ensure we handle multiple values for aria-labelledby

    @RobinMalfait
    RobinMalfait committed May 3, 2023
    Configuration menu
    Copy the full SHA
    d681caa View commit details
    Browse the repository at this point in the history

Commits on May 4, 2023

  1. hoist regex

    @RobinMalfait
    RobinMalfait committed May 4, 2023
    Configuration menu
    Copy the full SHA
    6524708 View commit details
    Browse the repository at this point in the history

  2. drop child nodes instead of replacing its innerText 

    This makes it a bit slower but also more correct. We can use a cache on
another level to ensure that we are not creating useless work.
    @RobinMalfait
    RobinMalfait committed May 4, 2023
    Configuration menu
    Copy the full SHA
    652e628 View commit details
    Browse the repository at this point in the history

  3. add useTextValue to improve performance of getTextValue 

    This will add a cache and only if the `innerText` changes, only then
will we calculate the new text value.
    @RobinMalfait
    RobinMalfait committed May 4, 2023
    Configuration menu
    Copy the full SHA
    c5e7bab View commit details
    Browse the repository at this point in the history

  4. use better useTextValue hook

    @RobinMalfait
    RobinMalfait committed May 4, 2023
    Configuration menu
    Copy the full SHA
    054eb97 View commit details
    Browse the repository at this point in the history