Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate aria-expanded purely based on the open/closed state #2610

Merged
merged 2 commits into from
Jul 24, 2023
Merged

Calculate aria-expanded purely based on the open/closed state #2610

merged 2 commits into from
Jul 24, 2023

Commits on Jul 24, 2023

  1. define aria-expanded based on open/closed state 

    You shouldn't be able to open a Listbox/Menu/Combobox/... when the
component is in a disabled state, however if you open it, and then
disable it then it is still in an open state. Therefore the
`aria-expanded` should still be present.

This is also how other libraries behave.

It is also how the native `<select>` behaves. You can open it, disable
it programmatically and then you are still able to make a selection.

This seems enough evidence that this change is an improvement without
being a breaking change.

Fixes: #2602
    @RobinMalfait
    RobinMalfait committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    c6dc7d2 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Jul 24, 2023
    Configuration menu
    Copy the full SHA
    12a92bc View commit details
    Browse the repository at this point in the history