Submit form on Enter even if no submit-like button was found
#2613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
Enter even if no submit button was foundEnter even if no submit-like button was found
RobinMalfait
force-pushed
the
fix/issue-2611
branch
from
54af00d
to
cab0079
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR further improves the form compatibility by using
form.requestSubmit()when a submit-like button wasn't found in the first place. We still want the other code, otherwise potentiale.preventDefault()inside theonClickof the actual submit button wouldn't be called.It's only if we can't find a submit button that we want to try the
form.requestSubmit()way.We can't use the
form.submit()function, because then theformwill be submitted without going throughonSubmitlisteners on theformitself.Fixes: #2611