Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Vue <Portal> SSR hydration mismatches #2700

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Fix Vue <Portal> SSR hydration mismatches #2700

merged 5 commits into from
Aug 23, 2023

Commits on Aug 23, 2023

  1. Register portal based on element presence in the DOM 

    This always coincides with `onMounted` currently but that’s about to change
    @thecrypticace
    thecrypticace committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    95a3c9c View commit details
    Browse the repository at this point in the history

  2. Mount element lazily for portals 

    This prevent’s SSR hydration issues and matches the behavior of React’s `<Portal>` element
    @thecrypticace
    thecrypticace committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    80df5c9 View commit details
    Browse the repository at this point in the history

  3. Fix portal tests

    @thecrypticace
    thecrypticace committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    b68bed9 View commit details
    Browse the repository at this point in the history

  4. Update comment

    @thecrypticace
    thecrypticace committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    bb25902 View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @thecrypticace
    thecrypticace committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    2d23cf5 View commit details
    Browse the repository at this point in the history