Allow changes to the className prop when the <Transition /> component is currently not transitioning
#2722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
className prop when the Transitiong component is currently not transitioningclassName prop when the <Transition /> component is currently not transitioning
|
🤦♂️ |
thecrypticace
approved these changes
Aug 31, 2023
|
I think this change has caused a bug in transitions: #2939 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where updating the
classNamedidn't work.This was sort of deliberate because we didn't want React to diff and update the
classNameif we are currently transitioning. However, we didn't check for transitioning state itself. If the<Transition />component is currently not transitioning then changing the className should work as expected.Fixes: #2714