Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent default behaviour when clicking outside of a Dialog.Panel #2919

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Prevent default behaviour when clicking outside of a Dialog.Panel #2919

merged 2 commits into from
Jan 9, 2024

Commits on Jan 9, 2024

  1. use event.preventDefault() in the useOutsideClick on Dialog's 

    When using a `Dialog`, we should prevent the default behaviour of the
event that triggered the "close" in the `useOutsideClick` call.

We recently made improvements to improve outside click behaviour on
touch devices (#2572) but
due to the `touchend` event, the touch is still forwarded and therefore
a potential button _behind_ the "backdrop" will also be clicked. This is
not what we want.

Added the `event.preventDefault()` for the Dialog specifically because
there are other places where we use `useOutsideClick` and where we _do_
want the behaviour where the click just continues. A concrete example of
this is 2 `Menu`'s next to eachother where you open the first one, and
then click on the second one. This should close first one (outside
click) and open the second one (by not preventing the event)
    @RobinMalfait
    RobinMalfait committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    9ad9550 View commit details
    Browse the repository at this point in the history

  2. update changelog

    @RobinMalfait
    RobinMalfait committed Jan 9, 2024
    Configuration menu
    Copy the full SHA
    fb1fdf9 View commit details
    Browse the repository at this point in the history