Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don’t override explicit disabled prop for components inside <MenuItem> #2929

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

thecrypticace
Copy link
Contributor

Fixes #2921

Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
headlessui-react ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 8:31pm
headlessui-vue ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 16, 2024 8:31pm

@thecrypticace thecrypticace changed the title Don’t override explicit disabled prop inside <MenuItem> Don’t override explicit disabled prop for components inside <MenuItem> Jan 16, 2024
@thecrypticace thecrypticace merged commit 3b2a102 into main Jan 16, 2024
8 checks passed
@thecrypticace thecrypticace deleted the fix/dont-override-disabled branch January 16, 2024 20:34
RobinMalfait pushed a commit that referenced this pull request Apr 15, 2024
…tem>` (#2929)

* Don’t override explicit disabled prop inside `<MenuItem>`

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding disabled prop to <component> within MenuItem inside a <Menu> not working
1 participant