Ensure clicking a ComboboxOption after filtering the options, correctly triggers a change
#3180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Schedule a task in the next frame
This allows us to never leave the `input`, even when clicking on an option.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
RobinMalfait
changed the title
ComboboxOption correctly triggers a changeComboboxOption after filtering the options, correctly triggers a change
RobinMalfait
force-pushed
the
fix/issue-3178
branch
from
cd4642d
to
17503d5
Compare
thecrypticace
approved these changes
May 7, 2024
RobinMalfait
added a commit
that referenced
this pull request
May 8, 2024
…ctly triggers a change (#3180) * add mouse buttons * add `useDisposables` hook * add `useFrameDebounce` hook Schedule a task in the next frame * ensure we reset the `isTyping` flag correctly * use same `mousedown` API as we did in React This allows us to never leave the `input`, even when clicking on an option. * update changelog * format comments * inline `cb`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where typing into a Combobox (filtering), and then clicking an option doesn't correctly choose the option.
We also made sure that the
ComboboxInputstays focused after selecting an option (even when clicking).Fixes: #3178