Fix prose-invert when used with colors in light mode
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
LGTM |
reinink
force-pushed
the
fix-invert-with-colors
branch
from
a5f9749
to
54c0fd1
Compare
This was referenced May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #228
This PR fixes an issue where
prose-invertwasn't working when used with aprose-{color}modifier while in light mode. For example:Prior to this fix you'd get this:
With this change, you get this:
The solution here is what @adamwathan suggested in the linked issue, where we need to make sure that the
invertstyles come last in the list of modifiers — which causes them to be generated last in the outputted CSS.