Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't prefix classes in arbitrary variants #10214

Merged
merged 6 commits into from Jan 3, 2023
Merged

Don't prefix classes in arbitrary variants #10214

merged 6 commits into from Jan 3, 2023

Commits on Jan 3, 2023

  1. Add tests

    @thecrypticace
    thecrypticace committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    946e68a View commit details
    Browse the repository at this point in the history

  2. Refactor 

    refactor
    @thecrypticace
    thecrypticace committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    38a9f39 View commit details
    Browse the repository at this point in the history

  3. Allow prefixSelector to take an AST

    @thecrypticace
    thecrypticace committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    dabe143 View commit details
    Browse the repository at this point in the history

  4. Consider multiple formats in finalizeSelector 

    The functions `finalizeSelector` and `formatVariantSelector` together were using a mix for AST and string-based parsing. This now does the full transformation using the selector AST. This also parses the format strings AST as early as possible and is set up to parse them only once for a given set of rules.

All of this will allow considering metadata per format string. For instance, we now know if the format string `.foo &` was produced by a normal variant or by an arbitrary variant. We use this information to control the prefixing behavior for individual format strings.
    @thecrypticace
    thecrypticace committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    3108ee6 View commit details
    Browse the repository at this point in the history

  5. Update changelog

    @thecrypticace
    thecrypticace committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    007ce19 View commit details
    Browse the repository at this point in the history

  6. Cleanup code a bit

    @thecrypticace
    thecrypticace committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    8e0352f View commit details
    Browse the repository at this point in the history