Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape group names in selectors #10276

Merged
merged 3 commits into from Jan 9, 2023
Merged

Conversation

thecrypticace
Copy link
Contributor

In v3.2.4 we would hard crash on the group variant group/${id}. This is because the name ${id}:

  1. Had { and } in it
  2. These were unescaped
  3. Even if manually escaped, we weren't handling this properly.

Here we fix this by doing two things:

  1. Escaping the group / peer names so they can appear in a selector un-modified.
  2. Handling escaped characters properly in a variant format string

Fixes #10266

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic nested groups names webpack error
1 participant