Always sort candidates #10382
Merged
Always sort candidates #10382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generated CSS order in Tailwind is not deterministic and depends on the order that Tailwind scans your template files, so if one machine happens to look at
User.jsxfirst and another looks atNavbar.jsxfirst, some things in the CSS file might be in a slightly different order even if nothing in the project has actually changed.Prior to this PR we would sort class candidates when running in a test environment to ensure identical output between our stable engine and new Rust engine for testing purposes. We didn't do this for real builds because sorting the class names detected in templates introduces a small performance penalty and doesn't impact the behavior of the final CSS, because we already sort the CSS to the degree it's actually necessary, for example ensuring all
px-*utilities come beforepl-*.With this PR, we always sort the candidates, which ensures deterministic output across different systems.
Resolves #10378.