Make font settings propagate into buttons, inputs, etc. #10940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
master
branch
3 times, most recently
from
62bd582
to
8dc0e57
Compare
|
Makes perfect sense, thanks for this one! |
|
@RobinMalfait @thecrypticace @reinink — good to merge this after updating the tests to account for the change in Preflight 👍 |
thecrypticace
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Make font settings propagate into buttons, inputs, etc. * update source-maps test due to preflight change * update changelog --------- Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
thecrypticace
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Make font settings propagate into buttons, inputs, etc. * update source-maps test due to preflight change * update changelog --------- Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
thecrypticace
pushed a commit
that referenced
this pull request
Jul 13, 2023
* Make font settings propagate into buttons, inputs, etc. * update source-maps test due to preflight change * update changelog --------- Co-authored-by: Robin Malfait <malfait.robin@gmail.com>
This was referenced May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Tailwind CSS v3.3 a feature was introduced to add font-feature-settings and font-variant-settings to the font-family config: https://tailwindcss.com/blog/tailwindcss-v3-3#configure-font-variation-settings-for-custom-font-families
These values are overriden by the user agent stylesheet for buttons, inputs, etc.
Since Tailwind CSS overrides the default behavior for the font-family value, I think it makes sense to add the same change for font-feature-settings and font-variant-settings.