Don’t move unknown pseudo-elements to the end of selectors #10962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`::test` is an unknown pseudo element and therefore may be actionable _and_ nestable
This works around the timeouts/flakeyness of GitHub Actions
RobinMalfait
force-pushed
the
fix/pseudo-deep
branch
from
5ebe085
to
a5073dd
Compare
thecrypticace
changed the title
::deep pseudo element to end of selector when using @apply
thecrypticace
changed the title
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This was referenced May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10960
The
::deepShadow DOM piercing selector uses invalid selector syntax but needs to still work for now. Here we've add it as an exception to ensure it is not moved to the end of the selector (which is the only place that pseudo elements can normally be placed).