Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with some pseudo-elements #11111

Merged
merged 2 commits into from Apr 27, 2023

Conversation

thecrypticace
Copy link
Contributor

We’ve included pseudo elements for ::backdrop, ::marker, ::placeholder, and ::selection and they were all “jumpable” before we made changes in v3.3.2. Ideally they wouldn’t be because if they ever eventually have any interactivity that could become a problem. However, we need to preserve backwards compatibility here so we'll mark them as such.

Fixes #11107

We’ve included pseudo elements for backdrop, marker, placeholder, and selection and they were all “jumpable” before we made changes in v3.3.2. Ideally they wouldn’t be because if they ever eventually have any interactivity that could become a problem.
@thecrypticace thecrypticace changed the base branch from master to 3.3 April 27, 2023 13:54
@thecrypticace thecrypticace merged commit ef056a5 into 3.3 Apr 27, 2023
@thecrypticace thecrypticace deleted the fix/pseudo-element-variant-selectors branch April 27, 2023 16:21
thecrypticace added a commit that referenced this pull request Jul 13, 2023
* Fix issues with some pseudo-elements

We’ve included pseudo elements for backdrop, marker, placeholder, and selection and they were all “jumpable” before we made changes in v3.3.2. Ideally they wouldn’t be because if they ever eventually have any interactivity that could become a problem.

* Update changelog
thecrypticace added a commit that referenced this pull request Jul 13, 2023
* Fix issues with some pseudo-elements

We’ve included pseudo elements for backdrop, marker, placeholder, and selection and they were all “jumpable” before we made changes in v3.3.2. Ideally they wouldn’t be because if they ever eventually have any interactivity that could become a problem.

* Update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected behavior of pseudo-elements such as marker
1 participant