Move unknown pseudo elements outside of :is
#11345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thecrypticace
changed the title
:is:is
thecrypticace
changed the title
:is:is
thecrypticace
force-pushed
the
fix/move-more-pseudos
branch
from
2731dc0
to
1aec80b
Compare
thecrypticace
added a commit
that referenced
this pull request
Jul 13, 2023
thecrypticace
added a commit
that referenced
this pull request
Jul 13, 2023
thecrypticace
added a commit
that referenced
this pull request
Jul 13, 2023
This was referenced May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did a lot of refactoring previously to handle
::deep,::ng-deep, and::v-deep. However, we also made the decision to preserve the position of unknown pseudo elements.This has resulted in a bit too much churn. So we're hardcoding the list
::deep,::ng-deep, and::v-deepfor now. We do still, however, consider unknown pseudo elements to be "actionable" — meaning they can have user-action pseudo-classes attached to them. We will move the pseudo element and attached classes as a group when moving elements.Fixes #11331