Ensure variants with arbitrary values and a modifier are correctly matched in the RegEx based parser #12179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RobinMalfait
force-pushed
the
fix/issue-12169
branch
from
126227e
to
8f9a2ea
Compare
RobinMalfait
changed the title
thecrypticace
pushed a commit
that referenced
this pull request
Oct 23, 2023
…tched in the RegEx based parser (#12179) * add failing test * ensure variants can have modifiers in regex * update changelog
This was referenced May 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where variants with arbitrary values and with a modifier weren't correctly matched in the RegEx based parser.
Given this example:
The
group-[[data-can-play]:not([data-playing])]/parent:bg-red-300wasn't matched correctly. With this change it will be.Fixes: #12169