Improve glob handling for folders with (
, )
, [
or ]
in the file path
#12715
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where we assumed that
(
,)
,[
and]
were already properly escaped. This wasn't the case, let's fix it.This is also going to be a nice DX improvement for people using file based routers where the files and folders can contain any of the following characters:
()[]
In this PR, we will make sure to escape those characters, and we will also ensure that we don't double escape them if you already escaped them yourselfs. This means that the following 2 snippets will be equivalent:
Fixes: #12708